fix(Parcel): Do not try to unmount when parcel is already unmounted #117
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We are currently experiencing an issue where whenever SingleSPA is unmounting the Micro-Frontend which contains a parcel we get the following error basically telling us that we are trying to unmount a parcel which is already unmounted.
Investigation
After some investigation we found out that the parcel component is not checking if the parcel is actually mounted b
efore unmounting it. Using log points in chrome we confirmed our suspicion that it is coming from single-spa-vue.
This log is emitted right before trying to call the unmount function.
Solution
Add a check to make sure that the parcel is mounted before unmounting it. While checking the single-spa-react package we saw that they have implemented the same solution, most likely for the same issue, as you can see here.