Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Parcel): Do not try to unmount when parcel is already unmounted #117

Closed
wants to merge 1 commit into from
Closed

fix(Parcel): Do not try to unmount when parcel is already unmounted #117

wants to merge 1 commit into from

Conversation

AckermannJan
Copy link

@AckermannJan AckermannJan commented May 21, 2024

Problem
We are currently experiencing an issue where whenever SingleSPA is unmounting the Micro-Frontend which contains a parcel we get the following error basically telling us that we are trying to unmount a parcel which is already unmounted.

Investigation
After some investigation we found out that the parcel component is not checking if the parcel is actually mounted b
efore unmounting it. Using log points in chrome we confirmed our suspicion that it is coming from single-spa-vue.
Bildschirmfoto 2024-05-21 um 17 43 26
This log is emitted right before trying to call the unmount function.

Solution
Add a check to make sure that the parcel is mounted before unmounting it. While checking the single-spa-react package we saw that they have implemented the same solution, most likely for the same issue, as you can see here.

@AckermannJan AckermannJan changed the title DRAFT: fix(Parcel): Do not try to unmount when parcel is already unmounted fix(Parcel): Do not try to unmount when parcel is already unmounted May 21, 2024
@AckermannJan
Copy link
Author

Hey @joeldenning, sorry to ping you directly, but would you be willing to do the review for this MR?

@AckermannJan AckermannJan closed this by deleting the head repository Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant